[rekonq] Re: Review Request: Escape Button stops a loading page

[Furkan Üzümcü]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100661/
-----------------------------------------------------------

(Updated Feb. 17, 2011, 7:03 p.m.)


Review request for rekonq.


Changes
-------

The issue is solved by changing the webStop() function in mainView. That function is only used by the stop action.


Summary
-------

Escape Button stops a loading page. I put the code in bool MainWindow::event(QEvent *event) so the escape shortcut won't have an issue to close completion widget.


Diffs (updated)
-----

  src/mainview.cpp dfa202d 
  src/mainwindow.cpp 24dc865 
  src/urlbar/urlbar.h 964534c 

Diff: http://git.reviewboard.kde.org/r/100661/diff


Testing
-------

Compiles and works.


Thanks,

Furkan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110217/02d78d4c/attachment.htm