[rekonq] Re: Review Request: highlight updated tabs

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/#review1348
-----------------------------------------------------------



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/100230/#comment1109>

    Suggestion for doing even better:
    void TabBar::setTabHighlighted(int index);
    void TabBar::resetTabHighlight(int index);
    
    Instead of passing a bool to decide the behavior.


I am still not sure about the code of setTabHighlighted().

Let say an evil page change the title webViewTitleChanged() every 15 ms, setTabHighlighted() will keep being called, the previous animation will stil be in memory. For me the animation needs to be stopped in this case.

Other example is a page change the title, you start the animation, you close the tab, reopen a tab, the animation continue on the new tab. For me the animation should stop when the tab is closed.

What do you think about that?

- Benjamin


On Feb. 10, 2011, 6:57 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100230/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2011, 6:57 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
> 
> I don't have a kde git account, so please merge it if you like it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7f9fe19 
>   src/mainview.cpp 66c86bc 
>   src/tabbar.h b505f78 
>   src/tabbar.cpp 7a8419a 
>   src/tabhighlighteffect.h PRE-CREATION 
>   src/tabhighlighteffect.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100230/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110210/860a88bd/attachment-0001.htm