[rekonq] Re: Review Request: Disable QNetworkAccessManager::CustomOperation code for KDE 4.5.96 and above

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100597/#review1298
-----------------------------------------------------------


This patch seems wrong to me. It drops out adblock management.

- Andrea


On Feb. 7, 2011, 2:51 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100597/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2011, 2:51 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> QNetworkAccessManager::CustomOperation has been implemented upstream in KDE Webkit, so this particular part of the code can be disabled for KDE Versions below 4.5.96
> 
> 
> Diffs
> -----
> 
>   src/networkaccessmanager.cpp 9d9101b 
> 
> Diff: http://git.reviewboard.kde.org/r/100597/diff
> 
> 
> Testing
> -------
> 
> Web browsing seems to work as usual, please let me know if you encounter any issues :)
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110207/b28f3c2e/attachment.htm