[rekonq] Re: Review Request: firefox4-like urlpreview

Rohan Garg rohangarg at kubuntu.org
Mon Feb 7 08:06:08 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100575/#review1282
-----------------------------------------------------------


It would be nice to have this feature for 0.7 imo, Firefox certainly seem to have got the url preview concept right, URL's are supposed to go in the urlbar. Those are my 2 cents ;)

- Rohan


On Feb. 5, 2011, 12:55 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100575/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2011, 12:55 p.m.)
> 
> 
> Review request for rekonq, Andrea Diamantini, Pierre Rossi, and Benjamin Poulain.
> 
> 
> Summary
> -------
> 
> firefox4-like urlpreview. replaces the preview popup at the lower left corner.
> i don't have a kde-git account, so please merge it if you like it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7f9fe19 
>   src/mainwindow.h 598d66e 
>   src/mainwindow.cpp 943f877 
>   src/urlbar/urlbar.h 964534c 
>   src/urlbar/urlbar.cpp f963be0 
>   src/urlbar/urlpreview.h PRE-CREATION 
>   src/urlbar/urlpreview.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100575/diff
> 
> 
> Testing
> -------
> 
> compiles and works.
> 
> 
> Screenshots
> -----------
> 
> urlPreview
>   http://git.reviewboard.kde.org/r/100575/s/71/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110207/e6baa564/attachment.htm 


More information about the rekonq mailing list