[rekonq] Re: Review Request: highlight updated tabs

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100230/#review1247
-----------------------------------------------------------

Ship it!


Apart from some glitches as pointed out by Furkan, it looks good to me now. I anyway would like to wait for comments from pierre and benjamin to merge it.
Many thanks for :D


- Andrea


On Feb. 4, 2011, 11:25 a.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100230/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 11:25 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch highlights inactive tabs if their title has changed, so people get aware of changes in the tabs (for instance a new message in a chat window).
> 
> I don't have a kde git account, so please merge it if you like it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7f9fe19 
>   src/mainview.cpp 66c86bc 
>   src/tabbar.h b505f78 
>   src/tabbar.cpp 7a8419a 
>   src/tabhighlighteffect.h PRE-CREATION 
>   src/tabhighlighteffect.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100230/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110205/5f36ecc0/attachment-0001.htm