[rekonq] Re: Review Request: The find bar is now closed with esc even with a shortcut override
Andrea Diamantini
adjam7 at gmail.com
Sat Feb 5 19:06:19 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100538/#review1246
-----------------------------------------------------------
src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100538/#comment1043>
Can you add here the same check for the (less used) zoombar?
- Andrea
On Feb. 5, 2011, 10:44 a.m., Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100538/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2011, 10:44 a.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> When the user defines a custom action for the esc key, the findbar isn't hidden with this key. This patch solves it.
>
>
> This addresses bug 264929.
> /show_bug.cgi?id=264929
>
>
> Diffs
> -----
>
> src/mainwindow.h 598d66e
> src/mainwindow.cpp 943f877
>
> Diff: http://git.reviewboard.kde.org/r/100538/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yoann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110205/42c3e65d/attachment.htm
More information about the rekonq
mailing list