[rekonq] Re: Review Request: GCI Task: Add an option to show the Favicon of the current site as window icon

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100312/#review1170
-----------------------------------------------------------



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100312/#comment972>

    Why that?



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/100312/#comment973>

    why not just "setWindowIcon(icon)"?



src/webview.cpp
<http://git.reviewboard.kde.org/r/100312/#comment974>

    You can probably save us from 3 calls to Application::instance(), setting a pointer here:
    MainWindow *w = Application::instance()->mainWindow();
    ...


- Andrea


On Feb. 1, 2011, 11:08 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100312/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2011, 11:08 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added an option, so that people who would like to have the Favicon of the current website as the icon of rekonq’s window, can enable it.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 6f8cd8b 
>   src/mainview.cpp 699103a 
>   src/mainwindow.h 598d66e 
>   src/mainwindow.cpp 943f877 
>   src/rekonq.kcfg d7d496f 
>   src/settings/settings_appearance.ui f7dd474 
>   src/tabbar.cpp 7a8419a 
>   src/webview.h a06a2cb 
>   src/webview.cpp d3eb2f4 
> 
> Diff: http://git.reviewboard.kde.org/r/100312/diff
> 
> 
> Testing
> -------
> 
> * Tested and works!
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110202/08e8e36a/attachment.htm