[rekonq] Re: Review Request: GCI Task: Limit the entries in the "Closed Tabs" right-click context menu

[Furkan Üzümcü]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100315/
-----------------------------------------------------------

(Updated Feb. 1, 2011, 11:34 p.m.)


Review request for rekonq.


Changes
-------

The patch limits the number of closed tabs history to 10 (it's 10 in Chrome and Firefox. That's the reason for the choice of the number)


Summary
-------

After a lon rekonq session, you often have closed *a lot* of tabs. If you then
accidentaly closed a tab and you want to open it up, rekonq will freeze, while
the Closed Tabs context menu is loading. This is due to the many entries in
that menu. 
Limiting the menu to 10 entries would make the situation better.
This also probably would solve the memory leak, that probably is caused by the
context menu.

If I use rekonq for a long time, and then close a lot of tabs, the RAM usage of
rekonq can go as high as 1.5 GB (yes, Gigabyte ;-))

https://bugs.kde.org/show_bug.cgi?id=240356


Diffs (updated)
-----

  src/mainview.cpp 699103a 

Diff: http://git.reviewboard.kde.org/r/100315/diff


Testing
-------

* Tested and works!


Thanks,

Furkan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110201/fcfd2c07/attachment.htm