[rekonq] Review Request: GCI Task: ADD A FOLDER COMBOBOX IN THE BOOKMARKWIDGET OF THE URLBAR

[Andrea Diamantini]

> On Dec. 20, 2011, 8:49 a.m., Andrea Diamantini wrote:
> > Please, rebase this patch and then update it.
> 
> Yusuf TEZCAN wrote:
>     i'm a new Kde developer :)
>     can you explain how to rebase a patch?

Sure :D
you probably have a git clone of rekonq code. Please, NEVER develop in master branch, just use it as "link" with remote repo.
So, checkout it:
$ git checkout master
and update your clone with last pushed code
$ git pull origin master
then go to your feature branch (the one where you implemented the patch). 
$ git checkout "featureBranch"
and rebase it
$ git rebase master
Your patch will be "lifted" to be the last thing committed.

Here you are. Feel free to ask me here on in IRC if you need more help.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103450/#review9112
-----------------------------------------------------------


On Dec. 18, 2011, 1:38 p.m., Yusuf TEZCAN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103450/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2011, 1:38 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> A combobox which contains root folders to move the current bookmark in it. I am a GCI-Student who wrote this patch.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkprovider.h fe49eae 
>   src/urlbar/bookmarkwidget.h e294bf1 
>   src/urlbar/bookmarkwidget.cpp 5beecb4 
> 
> Diff: http://git.reviewboard.kde.org/r/103450/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yusuf TEZCAN
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111229/0b49569c/attachment.html>