[rekonq] Review Request: Until now, when using a home page shortcut containing Ctrl, the home page would be opened in a new tab. This is changed

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103428/#review9021
-----------------------------------------------------------


This review has been submitted with commit beee4bb1f8f23a5b3b7da5187e385f5554314ca5 by Andrea Diamantini to branch master.

- Commit Hook


On Dec. 16, 2011, 1:43 p.m., Thomas Murach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103428/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 1:43 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Description
> -------
> 
> Functionality: see summary.
> Concerning the code: As far as I've seen, there is no "go to home page" button or anything like that. So the only way to visit the home page is to use a shortcut or to configure this as new tab action. Therefore it's not necessary anymore to care about middle mouse clicks or Ctrl+... events. That's why I also changed the argument list of MainWindow::homePage().
> If I'm mistaken on that, please correct me.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 8d827b0 
>   src/mainwindow.cpp 6b15385 
> 
> Diff: http://git.reviewboard.kde.org/r/103428/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Murach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20111216/f1af20d4/attachment.html>