[rekonq] Review Request: Change the "Paste & Go" action's text to "Paste & Search" if the content of the clipboard is not a URL

[Johannes Tröscher]

> On Aug. 31, 2011, 9:23 a.m., Andrea Diamantini wrote:
> > So, what about here? Furkan, Johannes, are you ok about this?
> 
> Furkan Üzümcü wrote:
>     This behavior is default in Chrome and a better way imho. I used the same check as in the open link in new tab context menu action and it's pretty accurate. I checked the accuracy with Chrome.
> 
> Andrea Diamantini wrote:
>     ok, waiting Johannes approval to merge :)

hm, i'm in doubt about the check. what if you try to paste a text like this "http://.asdf" or "||.||"?


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102441/#review6180
-----------------------------------------------------------


On Aug. 26, 2011, 10:11 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102441/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 10:11 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If the content of the clipboard is not a URL, the "Paste & Go" action's text is changed to "Paste & Search".
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 04d9698 
> 
> Diff: http://git.reviewboard.kde.org/r/102441/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110831/ccce64c2/attachment.html>