[rekonq] Fwd: Review Request: Unify reloading methods in reKonq

David Narvaez david.narvaez at computer.org
Tue Aug 30 12:12:30 UTC 2011


Resending, since list admins haven't been able to approve the original post
and we probably need to start reviewing this soon before 4.7.1.

David E. Narváez

---------- Forwarded message ----------
From: David Narváez <david.narvaez at computer.org>
Date: Sun, Aug 28, 2011 at 9:14 PM
Subject: Review Request: Unify reloading methods in reKonq
To: David Narváez <david.narvaez at computer.org>, rekonq <rekonq at kde.org>


   This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102481/
  Review request for rekonq.
By David Narváez.
Description

There are currently two families of methods handling reloads: one that
uses QWebView's reload method and one that does more sophisticated
handling of the about: scheme. This, apart from being an issue on its
own, produces a bug where reloading a tab from the Reload Tab and
Reload All Tabs tab context menu items cannot reload failed web pages
while reloading it from the Reload button in the toolbar can.

The proposed patch modifies all 3 reloading methods (including one
slot) by adding a webReload(WebTab *) slot that will ultimately handle
all reloads, and modifying the workflow of the other 3 methods in the
following way:

- webReload() -> webReload(WebTab *)
- reloadTab(int) -> webReload(WebTab *)
- reloadAllTabs() -> reloadTab(int) -> webReload(WebTab *)

  Testing

To reproduced the bug mentioned above:

1. Disconnect from the internet (I disable networking in my laptop),
open rekonq, open 3 tabs and access any web page in those three tabs
until you have all three tabs displaying error pages (Host Not Found).
2. Reconnect, and right click any tab, then do Reload Tab and Reload
All Tabs, nothing should happen
3. Go to any tab and click the Reload button from the toolbar, you
should be able to reload the web page

After applying the patch, you should be able to reload any tab from
the tab context menu or from the toolbar, and also reloading all
failed tabs from the Reload All Tabs item in the tab context menu.

  Diffs

   - src/mainview.h (ede1d62)
   - src/mainview.cpp (b573894)

View Diff <http://git.reviewboard.kde.org/r/102481/diff/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110830/2337f576/attachment.html>


More information about the rekonq mailing list