[rekonq] Review Request: highlight host in urlbar

[Johannes Tröscher]

> On Aug. 28, 2011, 3:23 p.m., Andrea Diamantini wrote:
> > It is really improved from the first version tried :)
> > Anyway, I think its behavior has to modified. In fact Firefox/Chrom* don't have a loading animation on their urlbar, so I really think this feature should work just on loadFinished (and probably also moved there). I mean that during page load, everything should be normal and "coloring" activated just on loadFinished.

should be just an easy check on progr. i'll post an updated version


- Johannes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102402/#review6099
-----------------------------------------------------------


On Aug. 27, 2011, 5:24 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102402/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 5:24 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> highlight host in urlbar like in firefox.
> this patch isn't finished yet.
> this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 04d9698 
> 
> Diff: http://git.reviewboard.kde.org/r/102402/diff
> 
> 
> Testing
> -------
> 
> compiles and works.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102402/s/238/
> 
>   http://git.reviewboard.kde.org/r/102402/s/239/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110828/9ae62d86/attachment.html>