[rekonq] Review Request: Change the "Paste & Go" action's text to "Paste & Search" if the content of the clipboard is not a URL

[Furkan Üzümcü]

> On Aug. 26, 2011, 4:18 a.m., Johannes Tröscher wrote:
> > src/urlbar/urlbar.cpp, line 486
> > <http://git.reviewboard.kde.org/r/102441/diff/1/?file=32913#file32913line486>
> >
> >     QUrl::fromUserInput(clipboardText).isValid() would be a better check if it's an url.
> >     maybe use a ternary operator here.
> >     eg. declare "a = new KAction(this):" and then
> >     a->setText(QUrl::fromUserInput(clipboardText).isValid() ? i18n("Paste && Go") : i18n("Paste && Search"));

That doesn't work. I tried it before.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102441/#review6017
-----------------------------------------------------------


On Aug. 26, 2011, 10:11 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102441/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 10:11 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If the content of the clipboard is not a URL, the "Paste & Go" action's text is changed to "Paste & Search".
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 04d9698 
> 
> Diff: http://git.reviewboard.kde.org/r/102441/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110826/218409b0/attachment-0001.html>