[rekonq] Review Request: highlight host in urlbar

[Johannes Tröscher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102402/
-----------------------------------------------------------

(Updated Aug. 25, 2011, 10:25 a.m.)


Review request for rekonq.


Changes
-------

use QUrl::fromUserInput() . don't use inactive textColor if host is empty.

unfortunatly there are still some bugs. i didn't find a way to have normal behaviour if the host is part of the selected text.
this bugs would not be present if i'd deactivate the "highlight-on-write" feature and follow firefox's behaviour (eg. don't highlight if the urlBar has focus)
what do you think?


Summary
-------

highlight host in urlbar like in firefox.
this patch isn't finished yet.
this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.


Diffs (updated)
-----

  src/urlbar/urlbar.cpp 04d9698 

Diff: http://git.reviewboard.kde.org/r/102402/diff


Testing
-------

compiles and works.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/102402/s/238/

  http://git.reviewboard.kde.org/r/102402/s/239/


Thanks,

Johannes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110825/cd09284d/attachment-0001.html>