[rekonq] Review Request: highlight host in urlbar
Johannes Tröscher
fritz_van_tom at hotmail.com
Wed Aug 24 18:21:02 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102402/
-----------------------------------------------------------
(Updated Aug. 24, 2011, 6:21 p.m.)
Review request for rekonq.
Changes
-------
removed the quirks adjam mentioned. host string is now calculated from text() because using the host of the tabs url is totally wrong if you changed the text.
highlights-on-write like in chromium.
this feature needs a lot of testing. please do so :)
Summary
-------
highlight host in urlbar like in firefox.
this patch isn't finished yet.
this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.
Diffs (updated)
-----
src/urlbar/urlbar.cpp 04d9698
Diff: http://git.reviewboard.kde.org/r/102402/diff
Testing
-------
compiles and works.
Screenshots
-----------
http://git.reviewboard.kde.org/r/102402/s/238/
http://git.reviewboard.kde.org/r/102402/s/239/
Thanks,
Johannes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110824/bae96aee/attachment.html>
More information about the rekonq
mailing list