[rekonq] Review Request: highlight host in urlbar
Johannes Tröscher
fritz_van_tom at hotmail.com
Tue Aug 23 10:37:55 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102402/#review5938
-----------------------------------------------------------
src/urlbar/urlbar.cpp
<http://git.reviewboard.kde.org/r/102402/#comment5247>
have a look at line 170. i just thought it's better not to hardcode it.
- Johannes
On Aug. 22, 2011, 11:18 a.m., Johannes Tröscher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102402/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2011, 11:18 a.m.)
>
>
> Review request for rekonq.
>
>
> Summary
> -------
>
> highlight host in urlbar like in firefox.
> this patch isn't finished yet.
> this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.
>
>
> Diffs
> -----
>
> src/urlbar/urlbar.cpp 17ba4bb
>
> Diff: http://git.reviewboard.kde.org/r/102402/diff
>
>
> Testing
> -------
>
> compiles and works.
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/102402/s/238/
>
> http://git.reviewboard.kde.org/r/102402/s/239/
>
>
> Thanks,
>
> Johannes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110823/4f806df8/attachment.html>
More information about the rekonq
mailing list