[rekonq] Review Request: highlight host in urlbar

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102402/#review5934
-----------------------------------------------------------


I really like this feature, but it seems having problems on its implementation. Here is my result: http://wstaw.org/m/2011/08/23/url_strange.png.
Moreover there is the private mode problem and a strange effect moving from 2nd levels hosts to deeper ones. Check in example loading "kde.org" and then "git.reviewboard.kde.org". I think effect should be applied just on loadFinished.
Last, I really prefer Chromium behavior than Firefox one. I really don't understand their choice to show anyway the 2nd level highlighted.

- Andrea


On Aug. 22, 2011, 11:18 a.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102402/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 11:18 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> highlight host in urlbar like in firefox.
> this patch isn't finished yet.
> this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 17ba4bb 
> 
> Diff: http://git.reviewboard.kde.org/r/102402/diff
> 
> 
> Testing
> -------
> 
> compiles and works.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102402/s/238/
> 
>   http://git.reviewboard.kde.org/r/102402/s/239/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110823/8f70c531/attachment.html>