[rekonq] Review Request: highlight host in urlbar

Johannes Tröscher fritz_van_tom at hotmail.com
Mon Aug 22 11:18:04 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102402/
-----------------------------------------------------------

(Updated Aug. 22, 2011, 11:18 a.m.)


Review request for rekonq.


Changes
-------

reverted changes of last patch, better follow chromium :D
changed hardcoded backgroundcolor in private mode.


Summary
-------

highlight host in urlbar like in firefox.
this patch isn't finished yet.
this code also evaluates the actual textrect including all margins, so the "empty-progress==0" message will be drawn in the "real" center.


Diffs (updated)
-----

  src/urlbar/urlbar.cpp 17ba4bb 

Diff: http://git.reviewboard.kde.org/r/102402/diff


Testing
-------

compiles and works.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/102402/s/238/

  http://git.reviewboard.kde.org/r/102402/s/239/


Thanks,

Johannes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110822/5516211d/attachment.html>


More information about the rekonq mailing list