[rekonq] Review Request: fix saving in adblock widget

Commit Hook null at kde.org
Thu Aug 18 23:29:10 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102362/#review5807
-----------------------------------------------------------


This review has been submitted with commit b56648b2d624ad5933bbfae0dcac6f65bb96bd3b by Andrea Diamantini to branch master.

- Commit


On Aug. 18, 2011, 10:33 a.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102362/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 10:33 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> saving in adblock widget did not work because save() never got called.
> this patch fixes saving.
> 
> i did post it here on reviewboard, because i think, there are other things that became obsololet when the adblock widget was moved out of the config dialog (the changed() signal for instance) and i could integrate them in one patch.
> 
> 
> Diffs
> -----
> 
>   src/adblock/adblockmanager.cpp ff09fdc 
>   src/adblock/adblockwidget.h 08194ad 
>   src/adblock/adblockwidget.cpp 2928178 
> 
> Diff: http://git.reviewboard.kde.org/r/102362/diff
> 
> 
> Testing
> -------
> 
> compiles and works.
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110818/c5ee7eac/attachment.html>


More information about the rekonq mailing list