[rekonq] Review Request: notifyPopup improvements

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102105/#review5640
-----------------------------------------------------------


This review has been submitted with commit 13554fb69e7f1cc7cc08534b201f484930482636 by Johannes Troscher to branch master.

- Commit


On Aug. 2, 2011, 6:36 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102105/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 6:36 p.m.)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Summary
> -------
> 
> this patch changes two things in the notifypopup:
> first: it uses a QLabel that is drawn inside the window, instead of a KPassivePopup
> this makes possible, that you can view url-previews if the window is not the active one and you hover a link
> 
> second: it limits the size of the url-preview to the half size of the browser-screen like in firefox4.
> (it's a question of taste, i like it :D )
> 
> ......
> third: i think the code is a bit easier to read :)
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h e7a5207 
>   src/mainwindow.cpp 9d2f0ff 
> 
> Diff: http://git.reviewboard.kde.org/r/102105/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110811/a4a72aba/attachment-0001.html>