[rekonq] Review Request: Enable dropping dragged text into a text field on web page

Pierre Rossi pierre.rossi at gmail.com
Thu Aug 4 11:30:51 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102192/#review5387
-----------------------------------------------------------


Actually, this should work out of the box in QtWebKit 2.2, and doesn't for rekonq. The proper fix would probably to investigate why. Note that dragging text in the middle of a text field will be hard to do with your approach, so I'd say r- for now, since the problem is elswhere it seems.

- Pierre


On Aug. 3, 2011, 3:37 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102192/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 3:37 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> You couldn't drop text into a text field on a web page. Now you can.
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp f31d234 
> 
> Diff: http://git.reviewboard.kde.org/r/102192/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110804/82f302aa/attachment.html>


More information about the rekonq mailing list