[rekonq] Review Request: Enable dropping dragged text into a text field on web page

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102192/#review5342
-----------------------------------------------------------


Not sure if that's not something that should be fixed upstream in WebKit.


src/webview.cpp
<http://git.reviewboard.kde.org/r/102192/#comment4826>

    You probably want to make sure that you're not modifying elements not editable for the user. See:
    
    http://doc.qt.nokia.com/latest/qwebhittestresult.html#isContentEditable
    
    Also, if you're gonna use QWebElement, then you probably could just use setInnerXml or appendInside that sounds more robust and secure than evaluating JavaScript that could contain potentially anything (even evil stuff). 


- Pierre


On Aug. 3, 2011, 10:39 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102192/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 10:39 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> You couldn't drop text into a text field on a web page. Now you can.
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp f31d234 
> 
> Diff: http://git.reviewboard.kde.org/r/102192/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110803/a213853f/attachment.html>