[rekonq] Review Request: action to search with default searchEnine in marked text's context menu

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102180/#review5316
-----------------------------------------------------------


Looks good to me otherwise. Looks like somebody is on a patch spree ! ;)


src/webview.cpp
<http://git.reviewboard.kde.org/r/102180/#comment4807>

    We should probably  use the  %1 form for the default engine's name  (for right to left languages potentially, or any language where that name wouldn't end up at the end). And possibly use i18nc to provide the translator with information as to what %1 represents in the sentence. 


- Pierre


On Aug. 2, 2011, 2:25 p.m., Johannes Tröscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102180/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 2:25 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> action to search with default searchEnine in marked text's context menu
> 
> 
> Diffs
> -----
> 
>   src/webview.cpp 1490c9b 
> 
> Diff: http://git.reviewboard.kde.org/r/102180/diff
> 
> 
> Testing
> -------
> 
> compiles and works
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102180/s/215/
> 
> 
> Thanks,
> 
> Johannes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/rekonq/attachments/20110802/f07a7a85/attachment.html>