[rekonq] Review Request: Use of QSignalMapper for switchToTab() method in terms of code unification

[Thomas Murach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101246/
-----------------------------------------------------------

Review request for rekonq.


Summary
-------

The principle of tab switching by shortcut (switchToTab()) is pretty much the same as loading favorites by shortcut (loadFavorite(const int index)), therefore a similar code should be used for both method invocations. As I was recommended to use QSignalMapper for loadFavorite(...), this class is now also used for switchToTab(...) as well.
I couldn't figure out how to do this without having to instance another object of QSignalMapper class. Thus I have to use two seperate objects, which should be fine, I guess.


Diffs
-----

  src/mainview.cpp 19e4aae 
  src/mainwindow.cpp 1ded983 
  src/mainview.h d01bb5b 

Diff: http://git.reviewboard.kde.org/r/101246/diff


Testing
-------


Thanks,

Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110428/ffedc117/attachment-0001.htm