[rekonq] Re: Review Request: Fixes the size of a tab preview to a constant size.

[Tirtha Chatterjee]

> On April 27, 2011, 10:19 p.m., Andrea Diamantini wrote:
> > uhm... I'm actually changing my mind, starting being interested in this patch. I like the "general" idea to let previews being of the same size, BUT...
> > 1. Can we have them a bit more bigger??
> > 2. Why don't we "decore" them in the same way Opera does?
> > 
> > What do you guys think?

1. I believe you are right. And the aspect ratio is a problem too. On widescreen displays, previews appear in 16:9, which looks really weird. I feel that the aspect ratio should always be 4:3, cropped if necessary. What so you think?

2. What kind of decoration are you exactly referring to? The preview widgets themselves can be a bit more beautiful, agreed. But are you talking about Opera's scalable previews? Something like this? http://www.technama.com/wp-content/uploads/2009/06/opera_10_beta_1_tab_bar_610x300.png


- Tirtha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101062/#review2933
-----------------------------------------------------------


On April 8, 2011, 7:40 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101062/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 7:40 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Right now, the size of a tab preview keeps decreasing as tab size decreases. This patch fixes the size of preview to the default base width of a tab (the max width of the tab) which a tab has at the beginning.
> 
> 
> Diffs
> -----
> 
>   src/tabbar.cpp 1ab357f 
> 
> Diff: http://git.reviewboard.kde.org/r/101062/diff
> 
> 
> Testing
> -------
> 
> Tested. Working properly.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110427/204d52b6/attachment.htm