[rekonq] Re: Review Request: new: calling favorite pages via shortcut

[Thomas Murach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101043/
-----------------------------------------------------------

(Updated April 24, 2011, 7:12 p.m.)


Review request for rekonq.


Changes
-------

Making QSignalMapper non-member. Finally the code looks fine to me :)
If this gets accepted, could someone with write-permissions apply the patch for me? Thanks a lot.


Summary
-------

This patch adds the following functionality: Pressing Ctrl + 1 up to Ctrl + 9 will load the favorite page with number 1 ... 9 in the current tab. I find this very useful when using Opera.
This is my first patch. So please tell me if there is something to improve in my kind of coding / formatting / ...
The code itself is pretty much copied from the function SwitchToTab() in MainView. 
Numbers higher than 9 do not make sense as shortcuts (in my opinion) and are therefore omitted, as well as zero


Diffs (updated)
-----

  src/mainview.h acc2d8c 
  src/mainview.cpp b34acc3 
  src/mainwindow.cpp 7b4e3ee 

Diff: http://git.reviewboard.kde.org/r/101043/diff


Testing
-------

Yes. Couldn't find any problems.
For example pressing Ctrl + _Number_X_ doesn't crash if you have less than _Number_X_ favorite pages


Thanks,

Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110424/67252885/attachment.htm