[rekonq] Re: Review Request: Improve KBookmarkManager custom bar folder support

[Yoann Laissus]

> On April 21, 2011, 7:59 a.m., Andrea Diamantini wrote:
> > src/bookmarks/bookmarkstoolbar.cpp, line 230
> > <http://git.reviewboard.kde.org/r/101128/diff/1/?file=14440#file14440line230>
> >
> >     I learnt from previous discussions that QCursor::pos() has an heavy cost for systems.
> >     Can we try avoiding it saving the first call or relying on event->pos()?

QCursor::pos() doesn't cost a lot but the mapping to and from global yes.
We can't avoid it because a lot of different objects are connected to this eventFilter method.
So *watched can be a bookmark action, a bookmark folder menu or the bar itself.
In the future, I'll try to clean this function because it's became almost unmaintainable and very difficult to add new stuff.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101128/#review2795
-----------------------------------------------------------


On April 14, 2011, 9:09 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101128/
> -----------------------------------------------------------
> 
> (Updated April 14, 2011, 9:09 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> - A new option to set/unset the current bookmark bar folder in the context menu
> - Fix drag and drop with a custom folder
> - Fix a regression which affects BK bar drag and drop (5a53d2bf91dd)
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkowner.h 8f0cd3b 
>   src/bookmarks/bookmarkowner.cpp bfca6ef 
>   src/bookmarks/bookmarkscontextmenu.cpp a55f777 
>   src/bookmarks/bookmarkstoolbar.cpp 3667503 
> 
> Diff: http://git.reviewboard.kde.org/r/101128/diff
> 
> 
> Testing
> -------
> 
> Works well
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110422/bfb707cd/attachment.htm