[rekonq] Review Request: Hybrid "new tab page"

Pierre Rossi pierre.rossi at gmail.com
Thu Apr 21 20:00:21 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101171/
-----------------------------------------------------------

Review request for rekonq.


Summary
-------

The branch is here:
http://gitorious.org/~elproxy/rekonq/elproxys-rekonq/commits/hybridRebased

I rebased the whole beast again on top of master, but I suspect it'll need rebasing again by the time it's actually going to be integrated (which I volunteer for if that's the case). Since so many things are touched all over the place it conflicts easily with new changes in master.

I think a diff would be useless at this point since it'd spread on so many pages, so I guess it's easier to just checkout the branch and look at the commits with git log (-p might be helpful) and basically test and see what the change is all about.

There are still quirks (i.e. some things that currently work might break) but nothing that should be impossible to fix really, and I wouldn't mind getting bug reports on this at this point.

A big thanks to Benjamin for all the work he put into this.


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/101171/diff


Testing
-------

erm, no autotests for the individual components as of now, but I'm still considering it and thinking about how to do this properly.


Thanks,

Pierre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110421/a337e41f/attachment.htm 


More information about the rekonq mailing list