[rekonq] Re: Review Request: new: calling favorite pages via shortcut

[Thomas Murach]

> On April 18, 2011, 1:43 p.m., Felix Rohrbach wrote:
> > Thanks for the patch! I like it and it seems to work very good, just one style error (see below). Can you please fix that and then merge it?

Fixed. But I'm not able to merge because I don't have the rights to do so. Could someone else do that for me, please?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101043/#review2724
-----------------------------------------------------------


On April 9, 2011, 12:26 a.m., Thomas Murach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101043/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 12:26 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> This patch adds the following functionality: Pressing Ctrl + 1 up to Ctrl + 9 will load the favorite page with number 1 ... 9 in the current tab. I find this very useful when using Opera.
> This is my first patch. So please tell me if there is something to improve in my kind of coding / formatting / ...
> The code itself is pretty much copied from the function SwitchToTab() in MainView. 
> Numbers higher than 9 do not make sense as shortcuts (in my opinion) and are therefore omitted, as well as zero
> 
> 
> Diffs
> -----
> 
>   src/mainview.h acc2d8c 
>   src/mainview.cpp b34acc3 
>   src/mainwindow.h 9853ca3 
>   src/mainwindow.cpp 7b4e3ee 
> 
> Diff: http://git.reviewboard.kde.org/r/101043/diff
> 
> 
> Testing
> -------
> 
> Yes. Couldn't find any problems.
> For example pressing Ctrl + _Number_X_ doesn't crash if you have less than _Number_X_ favorite pages
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110419/5d5fa8e0/attachment.htm