[rekonq] Re: Review Request: GCI Task: Add support for adding Web Shortcuts through a context menu on a search field

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100338/#review2530
-----------------------------------------------------------


uhm... an HUGE amount of code to provide a super tiny feature. I usually don't like these situations. Waiting for other's comments.

- Andrea


On Feb. 4, 2011, 6:48 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100338/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 6:48 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added support for adding Web Shortcuts through a context menu on a search field. This doesn't require a search.xml (or something similar) file.
> It's like the one in Konqueror.
> 
> 
> Diffs
> -----
> 
>   src/opensearch/opensearchmanager.h a0543c5 
>   src/opensearch/opensearchmanager.cpp f6476af 
>   src/opensearch/searchengine.h 181085e 
>   src/opensearch/searchengine.cpp f407789 
>   src/urlbar/urlbar.cpp f963be0 
>   src/urlbar/webshortcutwidget.h 02ddaf1 
>   src/urlbar/webshortcutwidget.cpp 629e7fb 
>   src/webtab.h 7b7c3c7 
>   src/webtab.cpp 67a5f3b 
>   src/webview.h a06a2cb 
>   src/webview.cpp d3eb2f4 
> 
> Diff: http://git.reviewboard.kde.org/r/100338/diff
> 
> 
> Testing
> -------
> 
> I guess it works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110409/86698a61/attachment.htm