[rekonq] Re: Review Request: Fixes the size of a tab preview to a constant size.

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101062/#review2505
-----------------------------------------------------------



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2196>

    while you're at it, it'd be nice to replace this BASE_WIDTH_DIVISOR deine by a "static const int BaseWidthDivisor"



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2197>

    you don't need curly braces here



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2198>

    same here.


- Pierre


On April 8, 2011, 7:40 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101062/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 7:40 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Right now, the size of a tab preview keeps decreasing as tab size decreases. This patch fixes the size of preview to the default base width of a tab (the max width of the tab) which a tab has at the beginning.
> 
> 
> Diffs
> -----
> 
>   src/tabbar.cpp 1ab357f 
> 
> Diff: http://git.reviewboard.kde.org/r/101062/diff
> 
> 
> Testing
> -------
> 
> Tested. Working properly.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110408/bef71b20/attachment-0001.htm