[rekonq] Re: Review Request: Fixes the size of a tab preview to a constant size.

[Rohan Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101062/#review2502
-----------------------------------------------------------



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2189>

    Extra spaces, please fix



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2190>

    Extra spaces again



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2192>

    I'm not entirely sure if others would agree or not, but the formatting should be something like : 
    if(foo){
    bar
    }



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2191>

    And here again ..



src/tabbar.cpp
<http://git.reviewboard.kde.org/r/101062/#comment2193>

    Same error as pointed in the previous if statement, and i think this should be else if instead of just if


- Rohan


On April 8, 2011, 6:41 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101062/
> -----------------------------------------------------------
> 
> (Updated April 8, 2011, 6:41 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Right now, the size of a tab preview keeps decreasing as tab size decreases. This patch fixes the size of preview to the default base width of a tab (the max width of the tab) which a tab has at the beginning.
> 
> 
> Diffs
> -----
> 
>   src/tabbar.cpp 1ab357f 
> 
> Diff: http://git.reviewboard.kde.org/r/101062/diff
> 
> 
> Testing
> -------
> 
> Tested. Working properly.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110408/f87f2070/attachment-0001.htm