[rekonq] Re: Review Request: Make rekonq desktop aware

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101033/#review2485
-----------------------------------------------------------


I'm not sure about the current desktop preference (worth trying it for a little while), but favouring the most recently activated window(s) sounds good.

Just not quite a "Ship it" because of the swap logic.


src/application.h
<http://git.reviewboard.kde.org/r/101033/#comment2155>

    I'm not a big fan of this approach. How about making the app an event filter and installing it on each new mainWindow we create ?



src/application.cpp
<http://git.reviewboard.kde.org/r/101033/#comment2154>

    The order won't be right with a swap. I think you meant to takeAt and  prepend.



src/mainwindow.cpp
<http://git.reviewboard.kde.org/r/101033/#comment2156>

    this could be moved to Application::eventFilter()


- Pierre


On April 6, 2011, 8:28 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101033/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 8:28 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> If there is a rekonq window on the current virtual desktop and another application opens a link, rekonq will prefer this window. With this patch, rekonq also prefers windows that were activated most recently (old behaviour: most recently created).
> 
> branch: desktopAware
> 
> 
> This addresses bug 237732.
>     /show_bug.cgi?id=237732
> 
> 
> Diffs
> -----
> 
>   src/application.h 3cd3c96 
>   src/application.cpp 1fe936f 
>   src/mainwindow.cpp 7b4e3ee 
> 
> Diff: http://git.reviewboard.kde.org/r/101033/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110407/884271b9/attachment.htm