[rekonq] Re: Review Request: Use escape button to renew the url seen in the url bar

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101042/#review2470
-----------------------------------------------------------


I like this, too. I will test in the evening and eventually merge. Just a side notation: the problem pointed out by Felix depends on your code. You are using the currentTab()->view()->url() instead of the currentTab()->url(). One of the difference between the WebTab and the WebView url is exactly this: the first can manage our about urls. 

- Andrea


On April 7, 2011, 4:09 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101042/
> -----------------------------------------------------------
> 
> (Updated April 7, 2011, 4:09 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When something different than the url of the page is in the url bar, you hit escape and the url of the page is in the url bar.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 0a6783a 
> 
> Diff: http://git.reviewboard.kde.org/r/101042/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110407/5eb5db1c/attachment.htm