[rekonq] Re: Review Request: Use escape button to renew the url seen in the url bar

[Felix Rohrbach]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101042/#review2446
-----------------------------------------------------------


With normal urls, this patch works well and I really like it. But if you open some about:... page (e.g. the favorites page) and press escape there, the url bar text turns into "about:blank". If you then press enter, a blank page and not the favorites page is shown. You should show the right "about:" url here or leave the url bar empty.

Btw, there is a bug report about this feature: https://bugs.kde.org/show_bug.cgi?id=238886 

- Felix


On April 6, 2011, 7:06 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101042/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 7:06 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> When something different than the url of the page is in the url bar, you hit escape and the url of the page is in the url bar.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/urlbar.cpp 0a6783a 
> 
> Diff: http://git.reviewboard.kde.org/r/101042/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110406/f660be20/attachment.htm