[rekonq] Re: Review Request: Refresh all "about" pages when something "interesting" happens (a bookmark added for the bookmarks page and so on...)

[Pierre Rossi]

> On April 5, 2011, 10:28 p.m., Andrea Diamantini wrote:
> > Nice work :)
> > Needs fixes in the code, IMHO.

Hi all, 

Yeah I know, I've been pretty silent lately, but if I may: there would be a very elegant way of doing this with the new "new tab page", by just using plain Qt signals and a wee bit of javascript.
Now that 0.7 is out the door, maybe we should think about integrating this and working of top of it (yes, I'd have to rebase it once morefor this...)

And yes I'm trying to sneak my pet-project in, but at the same time it does exactly what you're trying to solve here, and potentially more.

Cheers,


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100895/#review2420
-----------------------------------------------------------


On April 5, 2011, 10:30 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100895/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 10:30 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Refresh all "about:bookmarks" pages when bookmarks are updated
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkprovider.cpp cef6eae 
>   src/protocolhandler.cpp 36efe2a 
>   src/webpage.h 09977bf 
>   src/webpage.cpp 3e2798d 
>   src/webview.cpp 16c9c2e 
> 
> Diff: http://git.reviewboard.kde.org/r/100895/diff
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110406/898aea73/attachment.htm