[rekonq] Re: Review Request: Refresh all "about:bookmarks" pages when bookmarks are updated

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100895/#review2419
-----------------------------------------------------------



src/protocolhandler.cpp
<http://git.reviewboard.kde.org/r/100895/#comment2080>

    uhm... I think this really cannot work properly. Add it on the ctor instead and provide an url check in the fullReload slot.



src/webpage.cpp
<http://git.reviewboard.kde.org/r/100895/#comment2081>

    I don't see the need for replicating this code here. Call the usual loadUrl slot and let rekonq do its job...


- Andrea


On March 28, 2011, 10:11 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100895/
> -----------------------------------------------------------
> 
> (Updated March 28, 2011, 10:11 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Refresh all "about:bookmarks" pages when bookmarks are updated
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkprovider.cpp cef6eae 
>   src/protocolhandler.cpp 36efe2a 
>   src/webpage.h 09977bf 
>   src/webpage.cpp 3e2798d 
>   src/webview.cpp 16c9c2e 
> 
> Diff: http://git.reviewboard.kde.org/r/100895/diff
> 
> 
> Testing
> -------
> 
> It works.
> 
> 
> Thanks,
> 
> Yoann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110405/d6a7aadd/attachment-0001.htm