[rekonq] Re: Review Request: Add bookmar by dragging and dropping the url from the urlbar

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101018/#review2416
-----------------------------------------------------------


In general I like this feature, but I don't like the way it is implemented. IMHO, you have in mind just your feature and are forgetting about everything else. When you drag text, IT IS TEXT. You cannot behave as it was an url. The icon in the drag object is nice, but I'm not sure it is ok for text. What if users drag urlbar content to an external application? Should they think they are dragging an url?
Last, we have another developer (Johannes Troscher) working on drag n drop features. This patch breaks his work, so it is a no go "as-is". 

- Andrea


On April 4, 2011, 4:18 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101018/
> -----------------------------------------------------------
> 
> (Updated April 4, 2011, 4:18 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Drag and rop the url from the urlbar to add it as a bookmark.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkstoolbar.cpp 8da30c6 
>   src/urlbar/urlbar.h 9ed89da 
>   src/urlbar/urlbar.cpp 4d53e17 
> 
> Diff: http://git.reviewboard.kde.org/r/101018/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110405/27771d75/attachment.htm