[rekonq] Re: Review Request: Add bookmar by dragging and dropping the url from the urlbar

[Furkan Üzümcü]

> On April 4, 2011, 9:03 a.m., Andrea Diamantini wrote:
> > What browser has this feature? I cannot reproduce this behavior in Firefox4 or Chrome.
> 
> Furkan Üzümcü wrote:
>     Chrome has it. Firefox does the same thing by dragging the tab. As the tab behaviour is different in Chrome you do it with the url in the urlbar. For example
>     1- Got to www.google.com
>     2- Select all the text in the url bar
>     3- Drag and drop it to the bookmark bar.
> 
> Andrea Diamantini wrote:
>     Ok, let's see if I understand your code, at least. You drag your text url from the urlbar and drop it inside the bookmark bar. Isn't it?

Yes. I changed your allow dragging in url bar patch. A lot.


- Furkan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101018/#review2378
-----------------------------------------------------------


On April 4, 2011, 4:18 a.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101018/
> -----------------------------------------------------------
> 
> (Updated April 4, 2011, 4:18 a.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Drag and rop the url from the urlbar to add it as a bookmark.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkstoolbar.cpp 8da30c6 
>   src/urlbar/urlbar.h 9ed89da 
>   src/urlbar/urlbar.cpp 4d53e17 
> 
> Diff: http://git.reviewboard.kde.org/r/101018/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110405/b68fc4f8/attachment.htm