[rekonq] Re: Review Request: Add bookmar by dragging and dropping the url from the urlbar

[Furkan Üzümcü]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101018/
-----------------------------------------------------------

(Updated April 4, 2011, 4:18 a.m.)


Review request for rekonq.


Changes
-------

I think adding an url that doesn't belong to the current web site isn't a good dea. The bookmark doesn't get updated. I think this way is better. You ca drag the text from the url bar but cannot drop it to the bookmarks toolbar.


Summary
-------

Drag and rop the url from the urlbar to add it as a bookmark.


Diffs (updated)
-----

  src/bookmarks/bookmarkstoolbar.cpp 8da30c6 
  src/urlbar/urlbar.h 9ed89da 
  src/urlbar/urlbar.cpp 4d53e17 

Diff: http://git.reviewboard.kde.org/r/101018/diff


Testing
-------

Compiles and works.


Thanks,

Furkan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110404/e1adc2b5/attachment.htm