[rekonq] Re: Review Request: Add bookmar by dragging and dropping the url from the urlbar

[Yoann Laissus]

> On April 3, 2011, 3:42 p.m., Yoann Laissus wrote:
> > If you drag an url without load it, the text of the bookmark will be the name of the previous loaded page. But, in this case, I don't know how to retrieve the correct name without creating a new QWebPage/View.
> > And you can add an icon to the QDrag (QDrag::setPixmap).
> 
> Furkan Üzümcü wrote:
>     Icons are set automatically. At least I don't have icon setting problem here.

I mean the icon shown during the drag :)
You can look at the bookmark toolbar dragging code.


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101018/#review2356
-----------------------------------------------------------


On April 3, 2011, 5:15 p.m., Furkan Üzümcü wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101018/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 5:15 p.m.)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Drag and rop the url from the urlbar to add it as a bookmark.
> 
> 
> Diffs
> -----
> 
>   src/bookmarks/bookmarkstoolbar.cpp 8da30c6 
>   src/urlbar/urlbar.h 9ed89da 
>   src/urlbar/urlbar.cpp 4d53e17 
> 
> Diff: http://git.reviewboard.kde.org/r/101018/diff
> 
> 
> Testing
> -------
> 
> Compiles and works.
> 
> 
> Thanks,
> 
> Furkan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20110403/edd6361e/attachment.htm