[rekonq] Re: Review Request: Fix icons handling for rekonq pages
Andrea Diamantini
adjam7 at gmail.com
Thu Oct 21 18:19:35 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100093/
-----------------------------------------------------------
(Updated 2010-10-21 16:19:35.049773)
Review request for rekonq.
Changes
-------
clean up webtab::url() method
Summary
-------
Fix icons handling for rekonq pages. The so called "rekonq pages" are the ones rekonq creates itself instead of letting WebKit retrieve them. This commit aims to fix them (_isOnRekonqPage variable in WebPage) and let icons work.
Diffs (updated)
-----
src/mainview.cpp 4ccbe93
src/mainwindow.cpp 4d3dfc9
src/newtabpage.cpp f5c9c18
src/protocolhandler.cpp 16af1f3
src/webpage.h b6e0c53
src/webpage.cpp 61c6a32
src/webtab.cpp 2289726
Diff: http://git.reviewboard.kde.org/r/100093/diff
Testing
-------
it works with all the "about" urls
Thanks,
Andrea
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101021/c3d114a8/attachment.htm
More information about the rekonq
mailing list