[rekonq] Re: Review Request: Multiple word highlighting: highlight the last char of a string as well.

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100091/
-----------------------------------------------------------

(Updated 2010-10-20 13:30:11.058039)


Review request for rekonq, Andrea Diamantini and Benjamin Poulain.


Changes
-------

Updated as per Benjamin's comments...  Hopefully for the last time ! ;)


Summary (updated)
-------

This patch essentially fixes the highlighting algorithm.

I f**ked up the first time and due to an offset here and an offset there, the last character of a string wouldn't be bold, even if it needed to.


Diffs (updated)
-----

  src/tests/listitem_test.cpp 961f4b6 
  src/urlbar/listitem.cpp 8b90814 

Diff: http://git.reviewboard.kde.org/r/100091/diff


Testing
-------

Typed "ciao" and "test" in the urlbar, as first pointed out by Andrea.
Added this entry to the existing autotest.


Thanks,

Pierre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101020/0a319498/attachment.htm