[rekonq] Re: Review Request: Multiple word highlighting: highlight the last char of a string as well.

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100091/#review143
-----------------------------------------------------------



src/tests/listitem_test.cpp
<http://git.reviewboard.kde.org/r/100091/#comment124>

    That is testing a particular case. Please also test with text before the matched string.



src/urlbar/listitem.cpp
<http://git.reviewboard.kde.org/r/100091/#comment125>

    Please add spaces before and after the equal character.
    
    And no space after the parenthesis (after ++i).
    
    Damn it ;)



src/urlbar/listitem.cpp
<http://git.reviewboard.kde.org/r/100091/#comment128>

    When is (i == boldSections.size()) true since the loop run with the condition (i < boldSection.size())?
    
    If you want to check the end of the string, why do it in the loop and not at the end?



src/urlbar/listitem.cpp
<http://git.reviewboard.kde.org/r/100091/#comment127>

    Why do you use post-increment here? ;)


- Benjamin


On 2010-10-20 12:24:12, Pierre Rossi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100091/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 12:24:12)
> 
> 
> Review request for rekonq, Andrea Diamantini and Benjamin Poulain.
> 
> 
> Summary
> -------
> 
> Apart from the coding style, this patch essentially fixes the highlighting algorithm.
> 
> I f**ked up the first time and due to an offset here and an offset there, the last character of a string wouldn't be bold, even if it needed to.
> 
> 
> Diffs
> -----
> 
>   src/tests/listitem_test.cpp 961f4b6 
>   src/urlbar/listitem.cpp 8b90814 
> 
> Diff: http://git.reviewboard.kde.org/r/100091/diff
> 
> 
> Testing
> -------
> 
> Typed "ciao" and "test" in the urlbar, as first pointed out by Andrea.
> Added this entry to the existing autotest.
> 
> 
> Thanks,
> 
> Pierre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101020/460959b9/attachment-0001.htm