[rekonq] Re: Review Request: Multiple word highlighting: highlight the last char of a string as well.

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100091/#review142
-----------------------------------------------------------


I suggest you to split the patch in two commit: 1) fix the style. 2) fix the bug.
Otherwise it is two unrelated changes in one commit.


src/urlbar/listitem.cpp
<http://git.reviewboard.kde.org/r/100091/#comment123>

    A space is missing after the comma.


- Benjamin


On 2010-10-20 11:47:37, Pierre Rossi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100091/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 11:47:37)
> 
> 
> Review request for rekonq, Andrea Diamantini and Benjamin Poulain.
> 
> 
> Summary
> -------
> 
> Apart from the coding style, this patch essentially fixes the highlighting algorithm.
> 
> I f**ked up the first time and due to an offset here and an offset there, the last character of a string wouldn't be bold, even if it needed to.
> 
> 
> Diffs
> -----
> 
>   src/urlbar/listitem.cpp 8b90814 
> 
> Diff: http://git.reviewboard.kde.org/r/100091/diff
> 
> 
> Testing
> -------
> 
> Typed "ciao" and "test" in the urlbar, as first pointed out by Andrea.
> 
> 
> Thanks,
> 
> Pierre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101020/c1bc62e6/attachment.htm