[rekonq] Re: Review Request: Optimize rekonq protocol handling

[Benjamin Poulain]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100062/#review116
-----------------------------------------------------------



src/protocolhandler.cpp
<http://git.reviewboard.kde.org/r/100062/#comment77>

    KDE's coding convention, the bracket should be on the same line as the if().



src/protocolhandler.cpp
<http://git.reviewboard.kde.org/r/100062/#comment79>

    Typo: "itself" should probably be in one word here :)



src/protocolhandler.cpp
<http://git.reviewboard.kde.org/r/100062/#comment78>

    Coding convention as well.



src/protocolhandler.cpp
<http://git.reviewboard.kde.org/r/100062/#comment80>

    KDE's coding convention: no space after the opening parenthesis.


- Benjamin


On 2010-10-14 18:09:59, Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100062/
> -----------------------------------------------------------
> 
> (Updated 2010-10-14 18:09:59)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Summary
> -------
> 
> This patch makes rekonq handle all possible protocols that KDE can handle, huge protocol optimization imo
> 
> 
> Diffs
> -----
> 
>   src/protocolhandler.cpp be23684 
> 
> Diff: http://git.reviewboard.kde.org/r/100062/diff
> 
> 
> Testing
> -------
> 
> Works perfectly on Kubuntu 10.10, tested with magnet/apt/ftp/mailto links
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101018/ce3df516/attachment-0001.htm