[rekonq] Re: Review Request: Added a visit count parameter to the history. This will used expecially in the Awesome UrlBar ordering suggestions code.

[Pierre Rossi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100147/#review408
-----------------------------------------------------------


The comments are to be read in the reverse order but that's the idea.
We could put a //FIXME in the comments and decide to remove it in the next minor version or something. The point is just to make the transition smoother by keeping the old history entries for users upgrading Rekonq.


src/history/historymanager.cpp
<http://git.reviewboard.kde.org/r/100147/#comment301>

    and here, maybe replace with:
    
    if (ver < HISTORY_VERSION -1)



src/history/historymanager.cpp
<http://git.reviewboard.kde.org/r/100147/#comment300>

    to make the version transition smoother, we should still read the other fields for the version before the current one.
    I'd rather see:
    
    if (ver == HISTORY_VERSION)
        stream >> item.visitCount;
    
    here


- Pierre


On 2010-11-21 22:38:52, Andrea Diamantini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100147/
> -----------------------------------------------------------
> 
> (Updated 2010-11-21 22:38:52)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Added a visit count parameter to the history. This will used expecially in the Awesome UrlBar ordering suggestions code.
> 
> It costs us a change in the HISTORY_VERSION and a temporary use of a new history file (called "history2")
> So, it needs further testing
> 
> 
> Diffs
> -----
> 
>   src/history/historymanager.h 1e03fb1c9dceb6388de0b121b7f46feb255cc3ea 
>   src/history/historymanager.cpp 92f9caeea905f6c0bb21b28c19e4364a62cef0a3 
>   src/history/historymodels.h d193cf860e25da1b650dd3b37d406e65f1511df0 
>   src/history/historymodels.cpp 793ff7e50dfb2eef97f84480dd5113fb3752f88a 
> 
> Diff: http://git.reviewboard.kde.org/r/100147/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101125/63d868ef/attachment.htm