[rekonq] Re: Review Request: Adding the feature to Open with Preferred application and Open with options

[Andrea Diamantini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100164/#review397
-----------------------------------------------------------


oops... I finally spent a couple of minutes downloading your patch and really testing it. I don't think we can really apply it as this completely breaks rekonq feature of embedding parts. IMHO, this is a no-go.

- Andrea


On 2010-11-22 19:31:36, Chinmaya Padhi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100164/
> -----------------------------------------------------------
> 
> (Updated 2010-11-22 19:31:36)
> 
> 
> Review request for rekonq.
> 
> 
> Summary
> -------
> 
> Adding the feature of Open with Preferred Application and Open With options , while clicked on a file . 
> 
> 
> Diffs
> -----
> 
>   src/webpage.cpp 2347b6d 
> 
> Diff: http://git.reviewboard.kde.org/r/100164/diff
> 
> 
> Testing
> -------
> 
> Tested on various files by clicking on them and opening them in the preferred application. It works fine .
> 
> 
> Thanks,
> 
> Chinmaya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101124/6c7fde65/attachment.htm