[rekonq] Re: Review Request: Ctrl+Shift+Delete shortcut to clear private data from rekonq

[Pierre Rossi]

> On 2010-11-21 21:53:47, Andrea Diamantini wrote:
> > Ok, looks good :)
> > I have a question for the "experts". What's the difference between Qt::ControlModifier & Qt:CTRL? And what has to be used?

See http://doc.qt.nokia.com/4.7/qt.html#Modifier-enum
I personally like ControlModifier, I find it clearer what it stands for (there's no confusing it with say Qt::Key_Control).


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100161/#review387
-----------------------------------------------------------


On 2010-11-21 12:02:13, Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100161/
> -----------------------------------------------------------
> 
> (Updated 2010-11-21 12:02:13)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Summary
> -------
> 
> Add the Ctrl+Shift+Delete shortcut to clear private data from rekonq. Can be found in shortcuts branch of http://gitweb.kde.org/clones/rekonq/garg/rekonq_shadeslayer.git
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp f662d7a 
> 
> Diff: http://git.reviewboard.kde.org/r/100161/diff
> 
> 
> Testing
> -------
> 
> Yes, works for me
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101121/36d47ca7/attachment.html